Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address further review of unregistered type handler #10776

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

brandonpayton
Copy link
Member

Description

This PR follows up on post-merge review comments for #8274 (added unregistered type handler).
#8274 (comment)
#8274 (comment)

How has this been tested?

Ran automated tests. Manually tested by changing and saving content around unregistered blocks, re-enabling a plugin that registers the missing blocks, and reloading to observe that the content was preserved.

@brandonpayton brandonpayton added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 19, 2018
@brandonpayton brandonpayton self-assigned this Oct 19, 2018
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Thanks

@brandonpayton brandonpayton merged commit 274348e into master Oct 19, 2018
@brandonpayton
Copy link
Member Author

Thanks for the review!

@brandonpayton brandonpayton deleted the fix/unregistered-block-code-review-issues branch October 19, 2018 15:16
antpb pushed a commit to antpb/gutenberg that referenced this pull request Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants