Avoid creating new state references if unchanged #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
|
Thanks @BE-Webdesign ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #916
This pull request seeks to improve Redux state behavior for keys handling post updates, to ensure that a new object reference is only returned if in-fact a change has occurred. The effect is two-fold: It avoids unnecessary re-renders by allowing
react-redux's default pure render behavior to be effective, and may be used toward a goal of considering dirtiness as the presence of an undo history, since bothcombineUndoableReducersandcombineReducersdisregard unchanged state.Testing instructions:
Ensure unit tests pass: