Use nesting in cover image take 2 #10141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
add/nesting-cover-image-take-2
branch
2 times, most recently
from
65c7b19
to
a38eaf0
Compare
jorgefilipecosta
force-pushed
the
add/nesting-cover-image-take-2
branch
from
a38eaf0
to
f5eceb4
Compare
jorgefilipecosta
changed the title
jorgefilipecosta
added
[Type] Enhancement
jorgefilipecosta
force-pushed
the
add/nesting-cover-image-take-2
branch
3 times, most recently
from
0369961
to
5986e57
Compare
jorgefilipecosta
force-pushed
the
add/nesting-cover-image-take-2
branch
from
5986e57
to
3afd134
Compare
jorgefilipecosta
force-pushed
the
add/nesting-cover-image-take-2
branch
from
3afd134
to
054325a
Compare
|
Closed in favor of #10639. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5452 was created a long time ago and meanwhile, our nesting mechanism evolved a lot. Some PR's were extracted from it and were already merged. At the time we decided to not migrate yet nesting to cover image because the mechanism did not offer a good experience.
This PR is a take two to use nesting in the cover image so we can check if the nesting mechanism now is ready.
This is a first step in the following set of enhancements:
Rename cover image block to cover, add video/color background functionality.
How has this been tested?
I verified the cover image block works as expected, and existing cover images are automatically migrated.