Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix grammar.md manifest entry; (chore) update data docs #10014

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

mcsf
Copy link
Contributor

@mcsf mcsf commented Sep 18, 2018

Description

Follow-up on #9837 (comment). I'd mistakenly updated docs/manifest.json, which is auto-generated from other sources, including docs/root-manifest.json.

Testing

Run npm run docs:build, make sure that docs/manifest.json is kept intact (that the entry for grammar.md isn't removed).

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@mcsf mcsf added this to the 4.0 milestone Sep 18, 2018
@mcsf mcsf merged commit c9d3669 into master Sep 18, 2018
@mcsf mcsf deleted the fix/docs-grammar-root-manifest branch September 18, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants