The server-side rendering block matcher doesn't match blocks with - (hyphen) #882
Labels
[Feature] Block API
API that allows to express the block paradigm.
Good First Issue
An issue that's suitable for someone looking to contribute for the first time
[Type] Bug
An existing feature does not function as intended
Comments
lamosty
added
[Feature] Block API
lamosty
added a commit
that referenced
this issue
May 24, 2017
I also had to rename the block from core/latest-posts to core/latestposts since I think there's a bug in the server-side matcher -- it ignores block comments with hyphens: #882
lamosty
added a commit
that referenced
this issue
May 25, 2017
I also had to rename the block from core/latest-posts to core/latestposts since I think there's a bug in the server-side matcher -- it ignores block comments with hyphens: #882
aduth
added
the
Good First Issue
lamosty
added a commit
that referenced
this issue
Jun 5, 2017
I also had to rename the block from core/latest-posts to core/latestposts since I think there's a bug in the server-side matcher -- it ignores block comments with hyphens: #882
lamosty
added a commit
that referenced
this issue
Jun 7, 2017
I also had to rename the block from core/latest-posts to core/latestposts since I think there's a bug in the server-side matcher -- it ignores block comments with hyphens: #882
lamosty
added a commit
that referenced
this issue
Jun 8, 2017
* Add initial scaffolding for REST API Latest Posts block * Load 5 latest posts into unordered list * Refactor to `latest-posts` instead of `rest-api-latest-posts` * Move data fetchers to data.js file Props @mtias for the suggestion * Refactor edit() to render a React component Fixes the issue of having to use `attributes` to store the latest posts and is also nicer. * Add poststoshow attribute with a default value 5 * Add server-side rendering I also had to rename the block from core/latest-posts to core/latestposts since I think there's a bug in the server-side matcher -- it ignores block comments with hyphens: #882 * Use defaultProps to initialize postsToShow * Add various fixes according to the review * Fix linting errors * Rebase and fix eslint/WP coding standards * Add fn which loads server-side rendering of blocks This was lost in last rebase * Avoid small render* functions and put the whole rendering in render * Add full post content fixture * Abort the latest posts query if component is unmounted before response * Import __ from i18n instead of using wp.i18n.__ * Use class prop instead of React state to store posts request * Add basic posts to show attribute validation
|
Fixed via #1152. |
This was referenced Jan 24, 2023
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm building a "latest posts" block and am trying to add server-side rendering to it. However, it seems like the $open_matcher doesn't like hyphens in the block names. For example, when I removed the hyphen from
wp:core/latest-poststowp:core/latestposts, it matched my block./cc @youknowriad
The text was updated successfully, but these errors were encountered: