Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap text in button block is unnecessary? #6563

Closed
samikeijonen opened this issue May 3, 2018 · 1 comment · Fixed by #7110
Closed

Wrap text in button block is unnecessary? #6563

samikeijonen opened this issue May 3, 2018 · 1 comment · Fixed by #7110
Assignees
@tofumatt
Labels
[Type] Bug An existing feature does not function as intended

Comments

@samikeijonen
Copy link
Contributor

samikeijonen commented May 3, 2018 •
edited
Loading

Issue Overview

There is a Wrap text setting in Button block. However it doesn't do anything. It doesn’t add any classes and no visual change in the editor or front-end.

Steps to Reproduce (for bugs)

  1. Add button block
  2. Toggle Wrap text setting

Possible Solution

We should just probably remove the setting we don't use.

Screenshot

wrap text toggle setting

Related Issues and/or PRs

I think there is hard coded styles already added in PR #5662.
@samikeijonen samikeijonen mentioned this issue May 3, 2018
Closed
4 tasks
@karmatosed
Copy link
Member

It 'used' to do something but if it doesn't anymore as a result of that fix we absolutely should remove it.

@karmatosed karmatosed added the [Type] Bug An existing feature does not function as intended label May 7, 2018
@tofumatt tofumatt self-assigned this Jun 4, 2018
tofumatt added a commit that referenced this issue Jun 4, 2018
@tofumatt
fix: Remove "Wrap text" from Button settings (fix #6563)
7625f67
@tofumatt tofumatt mentioned this issue Jun 4, 2018
Merged
4 tasks
tofumatt added a commit that referenced this issue Jun 8, 2018
@tofumatt
fix: Remove "Wrap text" from Button settings (fix #6563) (#7110)
ec20d1d 
* fix: Remove "Wrap text" from Button settings (fix #6563)
* Remove further clear attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofumatt tofumatt

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove "Wrap text" from Button settings (fix #6563) WordPress/gutenberg
3 participants
@tofumatt @karmatosed @samikeijonen