Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover image tooltips for alignment are duplicated #6013

Closed
karmatosed opened this issue Apr 5, 2018 · 2 comments
Closed

Cover image tooltips for alignment are duplicated #6013

karmatosed opened this issue Apr 5, 2018 · 2 comments
Assignees
@jorgefilipecosta
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.0 RC

Comments

@karmatosed
Copy link
Member

The same alignment tooltip is used for both the image and text alignment, should this be the case?

align
align2
@karmatosed karmatosed added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Apr 5, 2018
@karmatosed karmatosed added [Type] Bug An existing feature does not function as intended [Type] Copy Issues or PRs that need copy editing assistance labels Apr 18, 2018
@jorgefilipecosta jorgefilipecosta self-assigned this Apr 18, 2018
@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels May 8, 2018
@jorgefilipecosta jorgefilipecosta removed their assignment Aug 1, 2018
@afercia
Copy link
Contributor

afercia commented Sep 10, 2018

This still happens on current master 3.8.0-rc.1 and applies also to align center, align right. The tooltips are generated based on the aria-label attributes and they need to be distinguished, to properly communicate assistive technology users what they're meant for.

@mtias mtias added this to the WordPress 5.0 milestone Oct 7, 2018
@NickOrtiz
Copy link

Should the copy in these locations read "Text align left" and "Image align left" for the different tooltips? Or is there more appropriate descriptive terminology we should be using?

@jorgefilipecosta jorgefilipecosta self-assigned this Oct 30, 2018
@jorgefilipecosta jorgefilipecosta mentioned this issue Oct 30, 2018
Merged
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Nov 1, 2018
jorgefilipecosta added a commit that referenced this issue Nov 8, 2018
@jorgefilipecosta
Fix: Cover image tooltips for alignment are duplicated (#11263)
f20c453 
## Description
Fixes: #6013

The same tooltip as used for Block Alignment and text Alignment.
This PR makes sure we use different tooltips for the text alignment buttons.
https://user-images.githubusercontent.com/253067/38373204-92586b58-38e8-11e8-8ec2-09e73368cacb.png

## How has this been tested?
I added a cover block and I checked that the tooltips for text alignment are in the format "Text align left/center/right" and block alignment tooltips are in the format "Text left/center/right"

## Screenshots <!-- if applicable -->
Before:
![align](https://user-images.githubusercontent.com/253067/38373204-92586b58-38e8-11e8-8ec2-09e73368cacb.png)
![align2](https://user-images.githubusercontent.com/253067/38373205-928a870a-38e8-11e8-8391-ce5135c7593a.png)

After:
![image](https://user-images.githubusercontent.com/11271197/47747203-b62a8f80-dc7f-11e8-86fd-970f642296ae.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgefilipecosta jorgefilipecosta

Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.0 RC
Development

No branches or pull requests
5 participants
@karmatosed @mtias @afercia @NickOrtiz @jorgefilipecosta