-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font Library: WordPress 6.5 Required Tasks #55277
Comments
Hello there. I opened ticket 59911 on the track concerning inconsistency brought by PR #54615 between the declaration of font family presets in theme.json and the generated |
👋🏼 Hey hey! Are you all able to share biweekly updates on how this work is progressing? It would help me loads with sharing updates to the broader community and coordinating testing as needed. |
Yes, here's an update from the last few weeks: Changes merged:#57282 to consolidate the existing endpoints the Font Library added and fix potential data sanitization problems. This change is a small step forward in implementing the API refactor. #57364 to eliminate code no longer required. #57368 to improve copy text. Most relevant changes in-process: |
@matiasbenedetto are you able to provide weekly updates at this stage? We're less than a month away from beta 1 and it's going to be critical that we're aware of how this feature is progressing 🌟 |
@annezazu yes, this is the report about the last two weeks: Changes discussed or merged:We continue working heavily of the API rest refactor and the required frontend changes around that. We discussed the requirement around a method for the extenders to turn off the library. We landed a solution consisting of adding a PHP filter: #55275. We discussed the need for a custom permission for managing fonts, and it seems like it has been discarded at least for now: We discussed and landed a solution around configuring the storage location for font assets: We added the ability to unregister font collections: We updated the Google fonts collection generation and replaced the older TTF files by the lighter WOFF2 files. Most relevant for the next days:Work on the feature branch around the API refactor that will include the frontend changes too and try to merge it to trunk. |
Quick update on the Font Library: the API refactor PR has been merged, ready for release with Gutenberg 17.6. We'll start on the backports for 6.5 soon. |
Consider this as a 'Nice to Have' Font Library: Global Styles > Typography sidebar – group related font sources #58403 |
As Editor Tech Leads, @youknowriad and I have been looking at how we can best support contributors with landing this (blessed) feature for the WordPress 6.5 release. I've spent some time looking at the code and how we could possibly seek to make the synchronisation to WP Core easier for folks to review. It's our feeling that it might be easier/more manageable to split the feature into its high level components and merge incrementally. I've taken the liberty of pulling together the following. It is a suggestion only and we will defer to contributors on how best to proceed so feel free to pull it apart and propose alternatives. Know that we are here to support you, so please reach out to and we're happy to jump in and assist as required. Thanks for all the work on this feature 🙇 ProposalThe items are listed in order of proposed merge into WP Core. Post Types registration and Low Level APIsAll Font Library post type registrations. These are required to allow the public facing elements (REST API and Post Types) to function.
REST API endpointsThe classes relating to REST need to be available before the Post Type registration is merge otherwise the
Public API methodsAll remaining methods/functions from |
Another update:
If you'd like to follow along, all the work is labeled with |
UpdateIn order to raise the x2 Core PRs we need the following:
It would also be nice to have the following (but these are not blockers to raising the Core PRs): |
Two more to add to the above to prep for the Core PRs |
Initial Font Library Core backport PR is open here WordPress/wordpress-develop#6027 |
Some additional feedback on the code is being addressed in Gutenberg and will need to be brought into the Core PR(s). |
Core PRs for the initial merge of this feature are: |
The initial merge of this feature into WordPress Core for the 6.5 release is complete. Thank you to everyone who contributed. @creativecoder @matiasbenedetto if you are able to ✅ off any PRs from the PHP Sync Issue and mark with |
Now that we are past the Beta 1 cut off point I'm removing this tracking issue from the 6.5 Project board. From now on the board should only contain individual bugs that we want to still fix before 6.5 gets released. |
I'm going to close this issue, as the tasks listed above have now all been completed and the feature is due to be released with WP 6.5. Further issues can be tracked using the |
What?
A list of tasks required to merge Font Library in WordPress core 6.5.
To do:
In progress:
Needs decision:
Done:
WP_FONTS_DIR
) #55063Nice to have:
Trac ticket to merge in core:
https://core.trac.wordpress.org/ticket/59166
The text was updated successfully, but these errors were encountered: