Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page List: missing menu-item-home class for Home Page item #29423

Closed
Tracked by #35521
jasmussen opened this issue Mar 1, 2021 · 1 comment · Fixed by #37301
Closed
Tracked by #35521

Page List: missing menu-item-home class for Home Page item #29423

jasmussen opened this issue Mar 1, 2021 · 1 comment · Fixed by #37301
Assignees
@georgeh
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

Description

This issue is related to #29422, but separate as one can be fixed without fixing the other.

In a navigation menu, you might have a "Home Page" item, that links to the homepage (as set in reading options):

Screenshot 2021-03-01 at 10 27 33

For existing WordPress themes and menus, the "Home" menu item gets an additional CSS class, menu-item-home, to denote its status. This allows themers to give a special visual treatment to this menu item, should they wish:

Screenshot 2021-03-01 at 10 28 39

This class is missing from the Page List block.

Step-by-step reproduction instructions

  • Insert a menu block, choose "Add all pages"
  • Publish and inspect the website
  • Note that the current-menu-item class is missing.
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels Mar 1, 2021
@jasmussen
Copy link
Contributor Author

Related: #20542

@jasmussen jasmussen mentioned this issue Mar 1, 2021
Closed
37 tasks
@jasmussen jasmussen mentioned this issue Apr 20, 2021
Closed
@priethor priethor mentioned this issue Oct 11, 2021
Closed
38 tasks
georgeh pushed a commit that referenced this issue Dec 10, 2021
Add menu-item-home class to Navigation for front page
16797bc 
Closes #29423
@georgeh georgeh mentioned this issue Dec 10, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 10, 2021
georgeh pushed a commit that referenced this issue Dec 17, 2021
Add menu-item-home class to Navigation for front page
91dc798 
Closes #29423
georgeh added a commit that referenced this issue Jan 6, 2022
@georgeh
Add menu-item-home class to Navigation for front page (#37301)
489acbf 
* Add menu-item-home class to Navigation for the front page

Closes #29423
Mamaduka pushed a commit that referenced this issue Feb 16, 2022
@georgeh @Mamaduka
Add menu-item-home class to Navigation for front page (#37301)
4544361 
* Add menu-item-home class to Navigation for the front page

Closes #29423
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgeh georgeh

Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add menu-item-home class to Navigation for front page WordPress/gutenberg
2 participants
@georgeh @jasmussen