Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media library module dates filter doesn't fully display #2202

Closed
paaljoachim opened this issue Aug 3, 2017 · 9 comments
Closed

Media library module dates filter doesn't fully display #2202

paaljoachim opened this issue Aug 3, 2017 · 9 comments
Assignees
@ianbelanger79
Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Milestone
Merge: Media

Comments

@paaljoachim
Copy link
Contributor

As I click to add an image I notice that the All Dates dropdown is cropped.

screen shot 2017-08-04 at 01 26 36
@karmatosed karmatosed changed the title Media library module crammed All Dates drop down ver 0.6 Media library module dates filter doesn't fully display Aug 4, 2017
@karmatosed karmatosed added [Feature] Media Anything that impacts the experience of managing media [Type] Bug An existing feature does not function as intended Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Aug 4, 2017
@karmatosed karmatosed added this to the Beta 0.8.0 milestone Aug 4, 2017
@karmatosed
Copy link
Member

Good catch, I can replicate.

@mtias mtias removed this from the Beta 0.8.0 milestone Aug 7, 2017
@mrxkon
Copy link

mrxkon commented Sep 7, 2017

Hello there! Trying to help so I picked up an easy one to try the workflow.

This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.

Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?

If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed :D

@youknowriad youknowriad added the [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. label Dec 22, 2017
@nielslange
Copy link
Contributor

Related to #4034. Potential fix can be found there as well.

@Soean Soean mentioned this issue Dec 29, 2017
Closed
@karmatosed karmatosed added this to the Merge Proposal milestone Jan 25, 2018
@Soean Soean mentioned this issue Apr 11, 2018
Closed
@karmatosed
Copy link
Member

Also worth noting: #6111

@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Media Apr 12, 2018
@designsimply
Copy link
Member

Tested and confirmed that "All dates" is still awkwardly cropped in the media modal.

screen shot 2018-07-23 at mon jul 23 4 52 27 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=13999&action=edit running WordPress 4.9.7 and Gutenberg 3.3.0 using Firefox 61.0.1 on macOS 10.13.6.

@ianbelanger79
Copy link
Contributor

Hi All,

I have a solution for this issue, but I would like to refer back to @mrxkon previous comment.

Hello there! Trying to help so I picked up an easy one to try the workflow.

This could be 'easily' patched but the thing is that the css is actually coming from the media-views.css that resides in wp-includes. This is caused because there is 1 select box missing the 'All media items' so the widths of the single select box have to be replaced.

Question: is this something manageable through Gutenberg's files, meaning can we actually override the admin .css like we would do with a theme / plugin in any other case or is it something of a no-no situation so it should be handle on core somehow ?

If we could do it through Gutenberg I'd love a little file guidance as I haven't found a proper place to put the styles needed

Could I get some insight on this? Where should I put the CSS that is needed to fix this issue?

Thanks

@ianbelanger79 ianbelanger79 mentioned this issue Jul 31, 2018
Merged
4 tasks
@ianbelanger79 ianbelanger79 self-assigned this Aug 1, 2018
@brandonpayton
Copy link
Member

brandonpayton commented Aug 8, 2018 •
edited
Loading

@mrxkon and @ianbelanger79, it looks like the best place to add a stopgap would be in a style.scss file that is a sibling and dependency of our MediaUpload component. If possible, it would be good to submit a patch to core for this issue and add a link to it with our Gutenberg fix, indicating the fix should be removed once it is patched in core.

youknowriad pushed a commit that referenced this issue Aug 8, 2018
@ianbelanger79 @youknowriad
Expand date filter select box width (#8335)
8deaf5e 
* Expand date filter select box width

Widens the "All Dates" select box in the "Add Media" modal window, so that the full placeholder text is shown. Fix for #2202

* Fix indentation issues
@ajitbohra
Copy link
Member

Ticket/Patch
https://core.trac.wordpress.org/ticket/44760

@youknowriad
Copy link
Contributor

I'm closing as this is fixed in Gutenberg.

nylen pushed a commit to nylen/wordpress-develop-svn that referenced this issue Jan 19, 2019
Media: Port date filter width fix from Gutenberg.
1234535 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202

git-svn-id: https://develop.svn.wordpress.org/trunk@44653 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this issue Jan 19, 2019
@getsource
Media: Port date filter width fix from Gutenberg.
544e7a3 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202

git-svn-id: https://develop.svn.wordpress.org/trunk@44653 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this issue Jan 19, 2019
@getsource
Media: Port date filter width fix from Gutenberg.
792d02d 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202
Built from https://develop.svn.wordpress.org/trunk@44653


git-svn-id: http://core.svn.wordpress.org/trunk@44484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this issue Jan 19, 2019
@getsource
Media: Port date filter width fix from Gutenberg.
d58b906 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202
Built from https://develop.svn.wordpress.org/trunk@44653


git-svn-id: https://core.svn.wordpress.org/trunk@44484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
svn2github pushed a commit to svn2github/wp-svn-2-git that referenced this issue Jan 20, 2019
Media: Port date filter width fix from Gutenberg.
837dd16 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202
Built from https://develop.svn.wordpress.org/trunk@44653


git-svn-id: http://core.svn.wordpress.org/trunk@44484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
miya0001 pushed a commit to cjk4wp/wordpress that referenced this issue Feb 11, 2019
Media: Port date filter width fix from Gutenberg.
5de054c 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202

git-svn-id: http://develop.svn.wordpress.org/trunk@44653 602fd350-edb4-49c9-b593-d223f7449a82
aaronjorbin pushed a commit to aaronjorbin/wordpress-develop that referenced this issue Feb 20, 2019
@getsource @aaronjorbin
Media: Port date filter width fix from Gutenberg.
962a078 
Ensures the entire date selection dropdown shows in the media modal.

Previously this was worked around in WordPress/gutenberg@8deaf5e in Gutenberg. This moves the rule to core, allowing the workaround to be removed in Gutenberg.

Props ianbelanger.
Fixes #44760.
See WordPress/gutenberg#2202

git-svn-id: https://develop.svn.wordpress.org/trunk@44653 602fd350-edb4-49c9-b593-d223f7449a82
Tug pushed a commit that referenced this issue May 12, 2020
@mkevins
Merge pull request #2202 from wordpress-mobile/master-1.27.0-to-develop
d1d5583 
Merge master back to develop for v1.27.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianbelanger79 ianbelanger79

Labels
[Feature] Media Anything that impacts the experience of managing media Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Milestone
Merge: Media
Development

No branches or pull requests