Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gallery: fix media modal configuration #1444

Closed
mtias opened this issue Jun 26, 2017 · 5 comments
Closed

Gallery: fix media modal configuration #1444

mtias opened this issue Jun 26, 2017 · 5 comments
Assignees
@mkaz
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Jun 26, 2017

The media modal should be opened in the "gallery mode" where you can click to select multiple images.
@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Jun 26, 2017
@mkaz mkaz mentioned this issue Jun 28, 2017
Merged
@mkaz mkaz mentioned this issue Jun 29, 2017
Closed
@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jun 29, 2017
@westonruter
Copy link
Member

Was this not implemented in 70c5b7f? The current behavior in the plugin seems to be the same as the classic post editor.

@mkaz mkaz self-assigned this Jul 18, 2017
@mkaz
Copy link
Member

mkaz commented Jul 18, 2017

@westonruter - the behavior in the change you referenced opened the correct gallery modal when editing a gallery. I've got a change coming in shortly that will open the correct modal when first creating the gallery. The big difference is the current incorrect method requires you to ctrl/cmd/shift click to select multiple images, while the correct method is to just click each image and they are automatically multiple selected.

@mkaz mkaz mentioned this issue Jul 18, 2017
Closed
@westonruter
Copy link
Member

@mkaz ok, then is this not a duplicate of #1401? I had opened a PR to fix the issue there: #1820.

@westonruter westonruter marked this as a duplicate of #1401 Jul 18, 2017
@mkaz
Copy link
Member

mkaz commented Jul 19, 2017

Ah, I didn't see #1401 until now - yes, it is a duplicate.
Let me test out your PR, I had some troubles when using the MediaUploadButton with how images get selected and inserted in.

@mkaz
Copy link
Member

mkaz commented Jul 20, 2017

Closing in favor of #1401 and PR #1820

@mkaz mkaz closed this as completed Jul 20, 2017
dratwas pushed a commit that referenced this issue Nov 14, 2019
@marecar3
revert missing toggle editor mode call (#1444)
e396206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mkaz @westonruter @mtias