Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inserter popover gets cutoff #1004

Closed
shaunandrews opened this issue Jun 2, 2017 · 2 comments · Fixed by #1193
Closed

Inserter popover gets cutoff #1004

shaunandrews opened this issue Jun 2, 2017 · 2 comments · Fixed by #1193
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@shaunandrews
Copy link
Contributor

screen shot 2017-06-02 at 11 09 52 am

I think the popover needs to be more aware of its surroundings, and adapt so its always in view.
@mtias mtias added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended labels Jun 2, 2017
@aduth
Copy link
Member

aduth commented Jun 8, 2017 •
edited
Loading

Much more obvious an issue now that we have a standalone "New Post" screen (#1065)

@mehigh
Copy link
Contributor

mehigh commented Jun 15, 2017

This can work if the JS would take into consideration the height of the .editor-visual-editor when adding the balloon - and when there isn't enough room to switch it to the bottom instead.

is-bottom-class-used-helps

This was referenced Jun 15, 2017
Closed
Closed
@aduth aduth mentioned this issue Jun 15, 2017
Merged
mehigh added a commit to xwp/gutenberg that referenced this issue Jun 15, 2017
@mehigh
WordPress#1004 - Fix linting error
a0a591e
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Mar 25, 2024
Open
@yassine4999 yassine4999 mentioned this issue Mar 26, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this issue Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Detect Inserter bounds collision by generic Popover component WordPress/gutenberg
4 participants
@shaunandrews @mehigh @mtias @aduth