Skip to content

Commit

Permalink
Framework: Remove deprecations slated for v3.5 removal
Browse files Browse the repository at this point in the history
  • Loading branch information
aduth committed Aug 7, 2018
1 parent e4d858c commit d8242a1
Show file tree
Hide file tree
Showing 30 changed files with 104 additions and 746 deletions.
2 changes: 0 additions & 2 deletions core-blocks/test/full-content.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ function normalizeParsedBlocks( blocks ) {

// Change client IDs to a predictable value
block.clientId = '_clientId_' + index;
// TODO: Remove in 3.5 "UID" deprecation.
delete block.uid;

// Walk each attribute and get a more concise representation of any
// React elements
Expand Down
144 changes: 74 additions & 70 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions packages/blocks/src/api/factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ export function createBlock( name, blockAttributes = {}, innerBlocks = [] ) {
// attributes, and their inner blocks.
return {
clientId,
// TODO: Remove from block interface in 3.5 "UID" deprecation.
uid: clientId,
name,
isValid: true,
attributes,
Expand All @@ -83,8 +81,6 @@ export function cloneBlock( block, mergeAttributes = {}, newInnerBlocks ) {
return {
...block,
clientId,
// TODO: Remove from block interface in 3.5 "UID" deprecation.
uid: uuid(),
attributes: {
...block.attributes,
...mergeAttributes,
Expand Down
4 changes: 2 additions & 2 deletions packages/blocks/src/api/test/factory.js
Original file line number Diff line number Diff line change
Expand Up @@ -1024,9 +1024,9 @@ describe( 'block factory', () => {

const transformedBlocks = switchToBlockType( block, 'core/updated-text-block' );

// Make sure the block UIDs are set as expected: the first
// Make sure the block client IDs are set as expected: the first
// transformed block whose type matches the "destination" type gets
// to keep the existing block's UID.
// to keep the existing block's client ID.
expect( transformedBlocks ).toHaveLength( 2 );
expect( transformedBlocks[ 0 ] ).toHaveProperty( 'clientId' );
expect( transformedBlocks[ 0 ].clientId ).not.toBe( block.clientId );
Expand Down
35 changes: 0 additions & 35 deletions packages/components/src/deprecated.js

This file was deleted.

Loading

0 comments on commit d8242a1

Please sign in to comment.