set postId when slug is changed

WordPress · Aug 11, 2020 · 61fa1bf · 61fa1bf
1 parent 27b5d91
commit 61fa1bf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/packages/block-library/src/template-part/edit/index.js b/packages/block-library/src/template-part/edit/index.js
@@ -24,9 +24,6 @@ export default function TemplatePartEdit( {
 
 	// Resolve the post ID if not set, and load its post.
 	const postId = useTemplatePartPost( _postId, slug, theme );
-	useEffect( () => {
-		setAttributes( { postId } );
-	}, [ postId ] );
 
 	// Set the post ID, once found, so that edits persist,
 	// but wait until the third inner blocks change,

diff --git a/packages/block-library/src/template-part/edit/name-panel.js b/packages/block-library/src/template-part/edit/name-panel.js
@@ -28,7 +28,7 @@ export default function TemplatePartNamePanel( { postId, setAttributes } ) {
 					setTitle( value );
 					const newSlug = cleanForSlug( value );
 					setSlug( newSlug );
-					setAttributes( { slug: newSlug } );
+					setAttributes( { slug: newSlug, postId } );
 				} }
 				onFocus={ ( event ) => event.target.select() }
 			/>