Framework: Make sure block assets are always registered before wp-edi…

…t-post script (#6448)

* Framework: Make sure block assets are always registered before wp-edit-post script

* Framework: Use domReady to make sure that all blocks are properly registered

edit-post/index.js

@@ -6,6 +6,8 @@ import { get, isString, some } from 'lodash';
 /**
  * WordPress dependencies
  */
+import { registerCoreBlocks } from '@wordpress/core-blocks';
+import domReady from '@wordpress/dom-ready';
 import { render, unmountComponentAtNode } from '@wordpress/element';
 import { deprecated } from '@wordpress/utils';
 
@@ -59,9 +61,6 @@ export function reinitializeEditor( target, settings ) {
  * @return {Object} Editor interface.
  */
 export function initializeEditor( id, post, settings ) {
-	const target = document.getElementById( id );
-	const reboot = reinitializeEditor.bind( null, target, settings );
-
 	if ( 'production' !== process.env.NODE_ENV ) {
 		// Remove with 3.0 release.
 		window.console.info(
@@ -84,16 +83,25 @@ export function initializeEditor( id, post, settings ) {
 		);
 	}
 
-	render(
-		<Editor settings={ migratedSettings || settings } onError={ reboot } post={ post } />,
-		target
-	);
+	return new Promise( ( resolve ) => {
+		domReady( () => {
+			const target = document.getElementById( id );
+			const reboot = reinitializeEditor.bind( null, target, settings );
+
+			registerCoreBlocks();
+
+			render(
+				<Editor settings={ migratedSettings || settings } onError={ reboot } post={ post } />,
+				target
+			);
 
-	return {
-		initializeMetaBoxes( metaBoxes ) {
-			store.dispatch( initializeMetaBoxState( metaBoxes ) );
-		},
-	};
+			resolve( {
+				initializeMetaBoxes( metaBoxes ) {
+					store.dispatch( initializeMetaBoxState( metaBoxes ) );
+				},
+			} );
+		} );
+	} );
 }
 
 export { default as PluginSidebar } from './components/sidebar/plugin-sidebar';

lib/client-assets.php

@@ -979,8 +979,9 @@ function gutenberg_editor_scripts_and_styles( $hook ) {
 	$script  = '( function() {';
 	$script .= sprintf( 'var editorSettings = %s;', wp_json_encode( $editor_settings ) );
 	$script .= <<<JS
-		window._wpLoadGutenbergEditor = wp.api.init().then( function() {
-			wp.coreBlocks.registerCoreBlocks();
+		window._wpLoadGutenbergEditor = new Promise( function( resolve ) {
+			wp.api.init().then( resolve );
+		} ).then( function() {
 			return wp.editPost.initializeEditor( 'editor', window._wpGutenbergPost, editorSettings );
 		} );
 JS;

package.json

@@ -17,6 +17,7 @@
 	"dependencies": {
 		"@wordpress/a11y": "1.0.6",
 		"@wordpress/autop": "1.0.4",
+		"@wordpress/dom-ready": "1.0.4",
 		"@wordpress/hooks": "1.1.6",
 		"@wordpress/i18n": "1.1.0",
 		"@wordpress/url": "1.0.3",