Data: Normalize queried pagination values as numeric

WordPress · Aug 4, 2018 · 37e0d7a · 37e0d7a
1 parent f9fffb0
commit 37e0d7a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/core-data/src/queried-data/get-query-parts.js b/packages/core-data/src/queried-data/get-query-parts.js
@@ -43,7 +43,7 @@ export function getQueryParts( query ) {
 		switch ( key ) {
 			case 'page':
 			case 'perPage':
-				parts[ key ] = value;
+				parts[ key ] = Number( value );
 				break;
 
 			default:

diff --git a/packages/core-data/src/queried-data/test/get-query-parts.js b/packages/core-data/src/queried-data/test/get-query-parts.js
@@ -25,4 +25,16 @@ describe( 'getQueryParts', () => {
 			stableKey: '%3F=%26&b=2',
 		} );
 	} );
+
+	it( 'encodes stable string key with page data normalized to number', () => {
+		const first = getQueryParts( { b: 2, page: 1, perPage: 10 } );
+		const second = getQueryParts( { b: 2, page: '1', perPage: '10' } );
+
+		expect( first ).toEqual( second );
+		expect( first ).toEqual( {
+			page: 1,
+			perPage: 10,
+			stableKey: 'b=2',
+		} );
+	} );
 } );