Merge pull request #224 from WordPress/add/tinymce-single/quote-2

Remove blockquote should remove entire blockquote
WordPress · Mar 9, 2017 · 040ba31 · 040ba31
2 parents aedd3d5 + 56ada58
commit 040ba31
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 9 deletions.
diff --git a/tinymce-single/blocks.js b/tinymce-single/blocks.js
@@ -87,6 +87,17 @@
 		getSelectedBlock: function() {
 			return wp.blocks.getSelectedBlocks()[0];
 		},
+		selectBlock: function( block ) {
+			var editor = window.tinyMCE.activeEditor;
+			var brs = block.getElementsByTagName( 'BR' );
+
+			// Has placeholder for text.
+			if ( brs.length ) {
+				editor.selection.setCursorLocation( brs[0].parentNode, 0 );
+			} else {
+				editor.selection.select( block );
+			}
+		},
 		extendBlock: function( settings ) {
 			var extendId = settings.extends;
 			var id = settings.namespace + ':' + settings.name;

diff --git a/tinymce-single/blocks/elements/blockquote/register.js b/tinymce-single/blocks/elements/blockquote/register.js
@@ -9,7 +9,20 @@ window.wp.blocks.registerBlock( {
 			classes: 'remove-formatting',
 			icon: 'gridicons-quote',
 			onClick: function( block, editor ) {
-				editor.formatter.remove( 'blockquote' );
+				var footer = block.querySelector( 'footer' );
+				var firstChild = block.firstChild;
+
+				if ( footer ) {
+					block.removeChild( footer );
+				}
+
+				while ( block.firstChild ) {
+					block.parentNode.insertBefore( block.firstChild, block );
+				}
+
+				block.parentNode.removeChild( block );
+
+				window.wp.blocks.selectBlock( firstChild );
 			}
 		},
 		{

diff --git a/tinymce-single/tinymce/block.js b/tinymce-single/tinymce/block.js
@@ -289,14 +289,7 @@
 								block.parentNode.replaceChild( content, block );
 							}
 
-							var brs = content.getElementsByTagName( 'BR' );
-
-							// Has placeholder for text.
-							if ( brs.length ) {
-								editor.selection.setCursorLocation( brs[0].parentNode, 0 );
-							} else {
-								editor.selection.select( content );
-							}
+							window.wp.blocks.selectBlock( content );
 
 							setTimeout( showBlockUI )
 						}