Don't use <span> for RichText element

WordPress · Jan 16, 2020 · 009db94 · 009db94
1 parent 8b62591
commit 009db94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/block-library/src/navigation-link/edit.js b/packages/block-library/src/navigation-link/edit.js
@@ -156,10 +156,8 @@ function NavigationLinkEdit( {
 					'has-link': !! url,
 				} ) }
 			>
-				<div>
+				<div className="wp-block-navigation-link__content">
 					<RichText
-						tagName="span"
-						className="wp-block-navigation-link__content"
 						value={ label }
 						onChange={ ( labelValue ) => setAttributes( { label: labelValue } ) }
 						placeholder={ itemLabelPlaceholder }
@@ -172,9 +170,9 @@ function NavigationLinkEdit( {
 						] }
 					/>
 					{ showSubmenuIcon &&
-						<span className="wp-block-navigation-link__submenu-icon">
+						<div className="wp-block-navigation-link__submenu-icon">
 							{ submenuIcon }
-						</span>
+						</div>
 					}
 					{ isLinkOpen && (
 						<Popover position="bottom center">

diff --git a/packages/block-library/src/navigation-link/editor.scss b/packages/block-library/src/navigation-link/editor.scss
@@ -70,6 +70,8 @@
 	}
 
 	&.has-link .wp-block-navigation-link__content {
+		display: flex;
+		align-items: center;
 		text-decoration: underline;
 	}