Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quality: Remove unused PHP classes #664

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Quality: Remove unused PHP classes #664

merged 1 commit into from
Jun 3, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jun 1, 2024

Since the settings page has been rebuilt using React, the following two PHP classes are no longer used anywhere:

  • CBT_Form_Messages
  • CBT_Theme_Form

madhusudhand
madhusudhand approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@madhusudhand madhusudhand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano merged commit c3666a5 into trunk Jun 3, 2024
2 checks passed
@t-hamano t-hamano deleted the quality/remove-unused-classes branch June 3, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhusudhand madhusudhand madhusudhand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t-hamano @madhusudhand