Flush cache after saving/creating/exporting themes #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
reviewed
May 29, 2024
mikachan
approved these changes
May 29, 2024
There was a problem hiding this comment.
This looks like it's working well, good detective work 👏
I tested by making sure I could reproduce the error on a new Pressable site, and then with the changes in this PR I updated templates in both TT4 and TT3 via CBT. The editor reloaded correctly both times 🎉
matiasbenedetto
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This pull request includes changes to flush the cache after creating new themes.
Fixes: #655
Why?
When the cache is not flushed, in plataforms using the WordPress cache utils, it could result in the editor loading a blank page.
This ensures that the cache is updated with the latest theme data.
How?
By calling
wp_cache_flush();after the creation of new themes and variations.How to test.