-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update modal width to 65vw #638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Modal
component can now define its width via the size
prop. What do you think about using this prop instead of defining width in CSS? However, when using this props, the modal's height will not be full.
<Modal
size="large"
>
</Modal>
b587221
to
1e81d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
I think this is an interesting idea and may be considered in another PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged /trunk and fixed a conflict and I think this is ready to come in too. It looks nice; thank you for doing this. :)
I fixed the conflicts to merge this and include it in the next release. |
This change brings the following UI changes.
65vw
(similar to font library in core)In addition to these UI changes, it also introduces a style-sheet for adding class definitions.