-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tags UI #630
Improve tags UI #630
Conversation
A great improvement! Could we use the opportunity to point to more details about the tags? https://make.wordpress.org/themes/handbook/review/required/theme-tags/ I tried something like the below (so that the style would match the Plugins bit below it) but I'm not sure that's the best way to do that. :?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very good, simple change. With the added link to tags info I think this is ready to bring in.
👍 Good change I like it. 🚢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @t-hamano feel free to merge when you're ready.
Inspired by #495
This PR replaces the tag's input UI from a text field to a
FormTokenField
component.76ac407043b2761675731f70ff8839bf.mp4
I believe this UI will have the following benefits:
Also, this PR is intended to change only the UI, so there are no internal changes. If this PR is considered the first step in improving the UI, I think the ideal UI logic is as follows:
get_theme_feature_list()
function are displayed as candidates, and tags that are not included in that array are not allowed.Below is a mockup suggestion.
Testing Instructions