New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Sidebar: Improve screen header UI #605

Merged

vcanales merged 1 commit into WordPress:trunk from t-hamano:enhancement/editor-sidebar-title

Apr 28, 2024

Contributor

t-hamano commented Apr 27, 2024

Fixes #604

This PR improves the UI in the title section of the editor sidebar and accomplishes the following:

The header UI mostly matches the Global Styles header.
Separate button and h2 title. This separates the button's focus outline from the title and also makes it suitable as markup.
Screen readers correctly say "Back" when the button has focus.
If it is an RTL language, the chevron icon changes from left to right.

Before	After

In implementing these, I mimicked ScreenHeader component in Gutenberg repo.


          Editor Sidebar: Improve screen title UI

e5b999e

vcanales approved these changes

View reviewed changes

Member

vcanales left a comment

Tested; looks good!

vcanales merged commit 1787f90 into WordPress:trunk

2 checks passed

t-hamano deleted the enhancement/editor-sidebar-title branch

April 28, 2024 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment