Removed unnecessary filter rejecting unsafe URLs #588
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the filter to allow unsafe URLs was unnecessary. I believe it was added to get the plugin to work as expected in a docker container (wp-env) and another solution was ultimately used to make that work anyway.
With this filter removed there should be no more problems as described in #584
Fixes #584
NOTE: I was unable to reproduce this with the steps provided in #584. However I'm sure it could be triggered given the function could be constructed multiple times with that logic.
To Test:
/asset
folder and referenced from the patternSince this was originally added to support the plugin in a docker environment (wp-env) that environment was used to verify that it is working as expected.