Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n: Make modal titles translatable #575

Merged
merged 1 commit into from
Apr 22, 2024
Merged

i18n: Make modal titles translatable #575

merged 1 commit into from
Apr 22, 2024

Conversation

t-hamano
Copy link
Contributor

This PR makes the titles of metadata modals and theme.json modals translatable.

image
image

mikachan
mikachan approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @t-hamano!

@mikachan mikachan merged commit a07987a into WordPress:trunk Apr 22, 2024
2 checks passed
@t-hamano t-hamano deleted the i18n/translate-modal-title branch May 1, 2024 01:21
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @mikachan