Include activated Fonts on theme zip export functions #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbking
force-pushed
the
fix/include-fonts-on-zip-export
branch
from
ebdcaab
to
d27beb8
Compare
vcanales
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously fonts were only "managed" with Create Block Theme on the "save" action.
This change includes the activated fonts in the exported zip action.
To test activate a font using the Font Manager.
Do NOT 'Save' the theme (that font will be persisted in the theme and this isn't the functionality we're adding).
Export the theme. Note that any font that is active is included in the exported theme's
theme.jsonand the assets it is referencing are included in/assets/fonts/*.Fixes: #558