-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitHub release workflows #542
Conversation
Refactor GitHub release workflows in order to comply with branch protection rules. The new process: 1. Run the "Create new release PR" manually, selecting the release type ("major", "minor", or "patch"). This will create a new branch including the Changelog update and the version bumo on the readme, create-block-theme.php, and package.json files. 2. Merging the PR created on the previous step will trigger the deploy workflow, which remains unchanged, except for the conditions added in order for it to run only if the merged PR matches the characteristics of automated release PR. 1. Fork this repo 2. Checkout this branch 3. Merge intro trunk on the fork 4. Run the workflow, a new PR should be created on the fork 5. Merge the PR; the automated deploy step will run. At this point, the only thing that you'll be able to test on the fork is that the deploy workflow correctly identifies the PR and branch as a new release. The deploy itself requires credentials only available on the parent repo. * add block themers as reviewers * prefix tag with v
925e21c
to
f6e562c
Compare
I have confirmed that this workflow works as expected per the instructions. Using a forked repository I got all the way to "Deploy to Wordpress" when merging the branch created with the workflow (which failed as noted should be expected due to no credentials on my fork... which was good since it was just a test run anyway. :) ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I mostly understand the code enough to approve it. :)
Tested it out and it works as described and desired.
🚢
Refactor GitHub release workflows in order to comply with branch protection rules.
Also removes google fonts related workflow.
The new process
Testing instructions