Fix browser warning error when clicking the reset button #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warning error when clicking the reset button.
resetAxes()is called to reset these two controls for variable fonts in the font file preview settings.However, on the "Manage Theme Fonts" and "Add Google Fonts" pages, these two components related to variable fonts are not rendered. In other words, the
<DemoTextInput>component is not passed props(axes,setAxes,resetAxes) regarding variable fonts.create-block-theme/src/google-fonts/index.js
Line 266 in cef22d8
create-block-theme/src/manage-fonts/index.js
Line 161 in cef22d8
As a result,
resetAxes()is undefined and causes an error.To avoid this error I used optional chaining (
?.).