Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix react warning error on font upload page #502

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Fix react warning error on font upload page #502

merged 1 commit into from
Jan 4, 2024

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jan 4, 2024

This PR fixes a React warning error caused by a component becoming uncontrolled. Uploading fonts should work as before.

71a1632df286e57373a81a2424bf30cd.mp4

mikachan
mikachan approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well, I can no longer see the React warning on the local fonts upload form page. Thank you!

@mikachan mikachan merged commit f6e37e1 into WordPress:trunk Jan 4, 2024
1 check passed
@MaggieCabrera MaggieCabrera mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikachan mikachan mikachan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-hamano @mikachan