feat: log stacktrace implementation used #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iTrooz
force-pushed
the
iTrooz/log-stacktrace-impl
branch
from
0107c52
to
011ad36
Compare
iTrooz
changed the title
iTrooz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1768
This pull request introduces changes to enhance the logging functionality in ImHex by displaying the stacktrace implementation used when showing a stack trace.
getStackTrace()inmain/gui/source/stacktrace.cppto return aStackTraceResultstruct, which includes both the stack frames and the name of the stacktrace implementation used (Windows,execinfo, orbacktracedepending on the compilation flags). This allows for the identification of the stacktrace implementation in the logs.printStackTrace()inmain/gui/source/crash_handlers.cppto log the name of the stacktrace implementation used before printing the stack frames. This ensures that the implementation name is clearly logged whenever a stack trace is printed due to a crash.For more details, open the Copilot Workspace session.