patterns: Added Kaydara FBX Binary format #271
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed a bug and added support for decompressing arrays. The pattern should be feature-complete now. |
|
Why did you decide to close the PR? WevWolv might have just missed it. |
|
Might have been a mistake yeah. I'm absolutely open for merging this |
|
Ah the original repo was deleted. I'll just merge it manually then. Thanks a lot for the effort! |
|
nestedList seems to have some issues that I could not fix. I discovered late that the pattern fails to cover some FBX files entirely and I have not been able to find the cause of it, but it seems to be related to the way I handled NodeRecord subtrees. Therefore I closed the PR because I did not want to submit something that is broken. Sorry for the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hexpat parses a binary FBX file to give a high-level overview of its contents.