Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Minecraft LCE save format #256

Merged
merged 8 commits into from
Jul 23, 2024
Merged

Conversation

DexrnZacAttack
Copy link
Contributor

No description provided.

@DexrnZacAttack
Copy link
Contributor Author

Very simple for now but I'll probs update it tomorrow or something; it's 3 am right now.

took forever lol cuz weird syntax
@DexrnZacAttack
Copy link
Contributor Author

updated to add files to pattern

@DexrnZacAttack
Copy link
Contributor Author

NBT Parsing!

@WerWolv
Copy link
Owner

WerWolv commented Jun 16, 2024

Hey, thanks a lot!
Could you please also add your pattern to the table in the readme and add a test file as described in the PR template?

@DexrnZacAttack
Copy link
Contributor Author

DexrnZacAttack commented Jun 29, 2024

Hey, thanks a lot! Could you please also add your pattern to the table in the readme and add a test file as described in the PR template?

Just saw this, sure!
Am updating the ImHex pattern right now.


// NOTE: This pattern was only tested on Nightly@974c4ba, things may break/not work on older versions.

#include <std/string.pat>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this line isn't needed in v1.35.4 of ImHex. The import line below should do just fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this line isn't needed in v1.35.4 of ImHex. The import line below should do just fine.

Alright I'll probably fix that in my hexpat later, right now I'm trying to find a good file for the example folder and fix some issues I had with the NBT library (TypeTag not found iirc)

@DexrnZacAttack
Copy link
Contributor Author

Finished updating, will put example files in soon!

TU033 is a pre-release version, which has a slightly different file format that I documented myself [here](https://github.com/Team-Lodestone/Documentation/blob/main/LCE/Pre-Release%20Save%20Format.md)

TU5 is a release version which uses the same file format used all the way up to latest TU (aka the last version released)

All of these saves have been decompressed from XMemCompress (iirc modified LZX)
Chunk data however is still compressed, because it's not meant to be uncompressed in the scope of reading the save.

https://github.com/Team-Lodestone/Documentation/blob/main/LCE/LCE%20File%20Versions.md
@DexrnZacAttack
Copy link
Contributor Author

Save files added! of course markdown doesn't work in descriptions for whatever reason so I will send here:

TU033 is a pre-release version, which has a slightly different file format that I documented myself here

TU5 is a release version which uses the same file format used all the way up to latest TU (aka the last version released)

All of these saves have been decompressed from XMemCompress (iirc modified LZX)
Chunk data however is still compressed, because it's not meant to be uncompressed in the scope of reading the save.

https://github.com/Team-Lodestone/Documentation/blob/main/LCE/LCE%20File%20Versions.md

@DexrnZacAttack
Copy link
Contributor Author

Should be ready.

@applecuckoo
Copy link
Contributor

pinging @WerWolv since he may have missed this

@WerWolv WerWolv merged commit 569e5c4 into WerWolv:master Jul 23, 2024
@WerWolv
Copy link
Owner

WerWolv commented Jul 23, 2024

Thanks a lot!

@DexrnZacAttack
Copy link
Contributor Author

Thanks a lot!

Yeah!
How does updating the patterns work btw... Do I just make another pull request?

@WerWolv
Copy link
Owner

WerWolv commented Jul 24, 2024

Exactly yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants