Clear breakpoints only within the same file. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation is now identical to mi-base one so this is no longer needed
|
This looks reasonable to me, @brownts @WebFreak001 do you see any reason to not pull it in? |
|
Looks reasonable to me as well. |
8 tasks
|
While I did not tested it @kvinwang obviously did, and we had an additional positive review - and it actually looks better to me then the original, too - so merged. Note: I'd still would like to see a refactoring of its use - see #306 (comment) - but that's a separate thing and possibly also a pure personal opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #230.
When user set/remove a breakpoint, code-debug will remove all breakpoints and then add back the ones within the same file. That cause the breakpoints in other files lost.
This patch is trying to fix it by removing only the ones within the same file.