Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/block styles template #40

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Conversation

khleomix
Copy link
Contributor

Closes

Hotfix

Link to test

Test Locally

Description

  • Block Template Update: Updated block templates for better consistency and structure.
  • Desktop Menu Cleanup: Removed unnecessary code and streamlined the desktop menu functionality for improved performance.
  • Responsive Mixin Update: Enhanced responsive mixin with range functionality for better control across different screen sizes.
  • Menu Style and Header Markup Fixes: Fixed issues with the styling and markup of the navigation menu and header, ensuring consistency across different devices.
  • SVG Markup Support for Logo: Added support for SVG logos, along with additional improvements to the header styles.
  • Mobile Navigation Styles Update: Improved the mobile navigation styles for a more user-friendly experience.
  • Icon Placement and Padding Fixes: Addressed minor alignment and spacing issues for icons and overall layout refinements.

Related Tickets & Documents

Mobile &

Core-Widgets-Blocks-.-WDSBT.mp4

Desktop Screenshots/Recordings

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions


Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix added bug Something isn't working enhancement New feature or request hotfix Urgent patches for critical issues. labels Sep 30, 2024
@khleomix khleomix self-assigned this Sep 30, 2024
Copy link
Contributor

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great. Thanks, and approved!

Copy link
Member

@lswilson lswilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks really good @khleomix - good to go!

@thatmitchcanter thatmitchcanter merged commit 7da44c3 into main Sep 30, 2024
4 checks passed
@thatmitchcanter thatmitchcanter deleted the hotfix/block-styles-template branch September 30, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request hotfix Urgent patches for critical issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants