Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/site editor index #1097

Merged
merged 19 commits into from
Sep 29, 2023

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Sep 29, 2023

Closes

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Test locally

Description

  • Fix site editor issues with blank page
  • Fix themejson styles
  • Fix logged Github issues referenced above
  • Updated dependencies logged by dependabot

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Site-Title-–-Just-another-WordPress-site

Page-not-found-–-Site-Title

Hello-world-–-Site-Title

Site-Title-–-Just-another-WordPress-site (1)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

Copy link
Member

@martinDolan martinDolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks JC!

@lepittenger
Copy link
Member

I'm still seeing the pagination links off to the side
Screenshot 2023-09-29 at 2 59 45 PM

Copy link

@aslamatwebdevstudios aslamatwebdevstudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the file at the line below, wrap it with <div class="is-layout-constrained"> to align pagination with content area.

<nav class="pagination-container" aria-label="<?php esc_attr_e( 'numeric pagination', 'wd_s' ); ?>">

Copy link

@aslamatwebdevstudios aslamatwebdevstudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good 👍

Copy link
Member

@lepittenger lepittenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@khleomix khleomix merged commit b8dfa4e into release/WDSUS-2-4.0-Theme-Revamp Sep 29, 2023
@khleomix khleomix deleted the feature/site-editor-index branch September 29, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants