Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding code for the acf block generated using CLI #1094

Conversation

aslamatwebdevstudios
Copy link

Closes

NA

What type of PR is this? (put an x to all applicable)

  • ๐Ÿ• Feature
  • ๐Ÿ› Bug Fix
  • ๐Ÿ“ Documentation Update
  • ๐ŸŽจ Style
  • ๐Ÿง‘โ€๐Ÿ’ป Code Refactor
  • ๐Ÿ”ฅ Performance Improvements
  • โœ… Test
  • ๐Ÿค– Build
  • ๐Ÿ” CI
  • ๐Ÿ“ฆ Chore (Release)
  • โฉ Revert

Link to test

Description

  • Assign custom classes automatically to the block if any are given from admin
  • Assign alignment classes automatically if applied
  • Assign anchor tag automatically to the block if applied

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • ๐Ÿ‘ yes
  • ๐Ÿ™… no, because they aren't needed
  • ๐Ÿ™‹ no, because I need help

Added to documentation?

  • ๐Ÿ“œ README.md
  • ๐Ÿ““ Confluence
  • ๐Ÿ™… no documentation needed

Others

  • ๐Ÿฆฎ Is this issue accessible? (Section 508/WCAG 2.0AA)
  • ๐Ÿ™Œ Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@aslamatwebdevstudios aslamatwebdevstudios changed the base branch from main to release/WDSUS-2-4.0-Theme-Revamp September 29, 2023 17:15
Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aslamatwebdevstudios looks good, I did have to remove your phpcs ignore and added the correct escaping function. If you have to use ignore, make sure to add the context. Thanks! This works great.

@khleomix khleomix merged commit bbcd83e into release/WDSUS-2-4.0-Theme-Revamp Sep 29, 2023
@khleomix khleomix deleted the feature/add-scaffolding-code-to-block branch September 29, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants