Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WDSUS-19: adds WDS Blocks category #1022

Merged
merged 1 commit into from
Jun 1, 2023
Merged

WDSUS-19: adds WDS Blocks category #1022

merged 1 commit into from
Jun 1, 2023

Conversation

gutnikInna
Copy link
Contributor

@gutnikInna gutnikInna commented May 30, 2023 •
edited
Loading

# Closes

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Description

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screenshot 2023-05-30 at 4 05 22 PM

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

https://webdevstudios.atlassian.net/wiki/spaces/wds1/pages/3021570257/WDS+Blocks+Category

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@gutnikInna gutnikInna requested a review from khleomix as a code owner May 30, 2023 20:04
@gutnikInna gutnikInna self-assigned this May 31, 2023
@khleomix khleomix changed the base branch from main to release/WDSUS-2-4.0-Theme-Revamp June 1, 2023 15:21
khleomix
khleomix approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @gutnikInna

@khleomix khleomix merged commit 2e095ca into release/WDSUS-2-4.0-Theme-Revamp Jun 1, 2023
3 checks passed
@khleomix khleomix deleted the feature/WDSUS-19-enable-block-namespace branch June 1, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khleomix khleomix khleomix approved these changes

Assignees

@gutnikInna gutnikInna

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gutnikInna @khleomix