This repository has been archived by the owner on Aug 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @chicoxyzzy! Co-Authored-By: lukewagner <mail@lukewagner.name>
Cc @Ms2ger |
It's hard to see where this differs from #21. Can you make your changes a PR against the |
will do. my klutziness I guess
…On Thu, Apr 4, 2019 at 12:31 PM Ben Smith ***@***.***> wrote:
It's hard to see where this differs from #21
<#21>. Can you make your
changes a PR against the refresh branch so it's easier to diff?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACAL0DBU9fkiOpS5E-3Ju_iunG6hgytiks5vdlMqgaJpZM4cblLW>
.
--
Francis McCabe
SWE
|
I can't reconstruct how, but somehow me merging #21 merged this PR too? Anyhow, now we have |
Yes
I messed something up. TBH that was my fit ever pr
On Thu, Apr 4, 2019 at 5:49 PM Luke Wagner ***@***.***> wrote:
I can't reconstruct how, but somehow me merging #21
<#21> merged this PR
too? Anyhow, now we have proposals/host-bindings/binding.bs and
everything else in proposals/webidl-bindings.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACAL0KvtO1pK7TxxDyzRp_cZWmYmTOtEks5vdp2ngaJpZM4cblLW>
.
--
Francis McCabe
SWE
|
No worries, it's definitely confusing when starting out. Maybe create a new PR that just moves |
lukewagner
pushed a commit
that referenced
this pull request
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of a spec for encoding webIDL in a binary format.
To be viewed as an adjunct to the eventual spec for host bindings