Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE11: ensure target.nodeName exists #197

Merged
merged 1 commit into from
Jun 4, 2019
Merged

IE11: ensure target.nodeName exists #197

merged 1 commit into from
Jun 4, 2019

Conversation

thebuilder
Copy link
Contributor

I've seen a few cases where IE11 throws this error:

Unable to get property 'toLowerCase' of undefined or null reference

See full example on Sentry: https://sentry.io/share/issue/f02ceb35bf504436a21a60c08154341d/

The e.target.nodeName in onInitialPointerMove is undefined, so attempting to read it throws an error.

This pull request adds an extra guard that checks if nodeName exists, before calling toLowerCase().

@robdodson
Copy link
Collaborator

LGTM. Restarting the travis build to see if i can make it happy.

@robdodson robdodson merged commit 7ca7f9c into WICG:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robdodson robdodson robdodson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thebuilder @robdodson