-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deploy refactor #22
deploy refactor #22
Conversation
* main: ov-deploy (#24)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
print(f'Starting deployment using context "{self.context}"') | ||
|
||
if not any([self.ov_wag, self.ov_frontend, self.ov_nginx]): | ||
raise Exception(f'Nothing specified for deployment.') | ||
if self.ov_wag: | ||
self.deploy_ov_wag() | ||
self._deploy('ov-wag', self.ov_wag, src=f'{OV_WAG_URL}#{self.ov_wag}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrharpo does this mean src
will always be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it's not needed in the nginx deploy, so we could remove it there.
self._deploy( | ||
'ov-frontend', | ||
self.ov_frontend, | ||
src=f'{OV_FRONT_URL}#{self.ov_frontend}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto above
deployer.py
Outdated
if self.ov_nginx: | ||
self.deploy_ov_nginx() | ||
self._deploy('ov-nginx', self.ov_nginx, src='ov-nginx') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to split ov-nginx
into it's own repo, we would need to explicitly point the src
to the github repo.
When we add the jumpbox
options to the CLI, it will not need the src
since it's building from a local file... until we split it into it's own repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Deploy
Refactord
deployer.py
to reduce repitionbuild_image(repo_name, tag, src)
src
- Because we might want to build from a source repo with tag or build only from local files:src
arg is when the docker build source needs to be different than the name of the reporepo#tag
push_image(repo_name, tag)
update_workload(pod, tag)
self._deploy()
self.deploy()
_deploy()
with custom args for eachcli
string arg for--ov-nginx
ov_nginx: str
Closes #19