deploy refactor #22
Merged
deploy refactor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrharpo
added
documentation 📜
12 tasks
* main: ov-deploy (#24)
afred
reviewed
Jul 27, 2022
| print(f'Starting deployment using context "{self.context}"') | ||
|
|
||
| if not any([self.ov_wag, self.ov_frontend, self.ov_nginx]): | ||
| raise Exception(f'Nothing specified for deployment.') | ||
| if self.ov_wag: | ||
| self.deploy_ov_wag() | ||
| self._deploy('ov-wag', self.ov_wag, src=f'{OV_WAG_URL}#{self.ov_wag}') |
There was a problem hiding this comment.
@mrharpo does this mean src will always be used?
There was a problem hiding this comment.
Yes, but it's not needed in the nginx deploy, so we could remove it there.
afred
reviewed
Jul 27, 2022
| self._deploy( | ||
| 'ov-frontend', | ||
| self.ov_frontend, | ||
| src=f'{OV_FRONT_URL}#{self.ov_frontend}', |
mrharpo
commented
Jul 27, 2022
deployer.py
Outdated
| if self.ov_nginx: | ||
| self.deploy_ov_nginx() | ||
| self._deploy('ov-nginx', self.ov_nginx, src='ov-nginx') |
There was a problem hiding this comment.
If we were to split ov-nginx into it's own repo, we would need to explicitly point the src to the github repo.
When we add the jumpbox options to the CLI, it will not need the src since it's building from a local file... until we split it into it's own repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy
Refactord
deployer.pyto reduce repitionbuild_image(repo_name, tag, src)src- Because we might want to build from a source repo with tag or build only from local files:srcarg is when the docker build source needs to be different than the name of the reporepo#tagpush_image(repo_name, tag)update_workload(pod, tag)self._deploy()self.deploy()_deploy()with custom args for eachclistring arg for--ov-nginxov_nginx: strCloses #19