Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Fixes pydantic models for tests #153

Merged
merged 1 commit into from
Feb 7, 2024
Merged

🔨 Fixes pydantic models for tests #153

merged 1 commit into from
Feb 7, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Feb 7, 2024

ExhibitsAPISchema

Fixes pydantic test models to reflect values coming from the API

@mrharpo mrharpo added bug 🐛 Something isn't working test 🧪 Tests and testing labels Feb 7, 2024
@mrharpo mrharpo self-assigned this Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96cf684) 91.36% compared to head (b761584) 91.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
+ Coverage   91.36%   91.47%   +0.10%     
==========================================
  Files          50       50              
  Lines         556      563       +7     
==========================================
+ Hits          508      515       +7     
  Misses         48       48              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrharpo mrharpo requested a review from foglabs February 7, 2024 17:58
@mrharpo mrharpo merged commit e5bd483 into main Feb 7, 2024
10 checks passed
@mrharpo mrharpo deleted the fix-tests branch February 7, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working test 🧪 Tests and testing
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants