Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to using upstream nginx image directly #18

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Migrate to using upstream nginx image directly #18

merged 1 commit into from
Jul 20, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jul 20, 2022

ov-nginx

  • Migrate ov-nginx image to use nginx image directly
  • Copy in conf file to image
  • Pushed to docker hub

nginx.conf

Because the new image contains the nginx.conf file, there is no longer any need to mount the config file in Rancher, unless a different configuration is wanted.

Closes #14

@mrharpo mrharpo added CD 🏗️ Relating to Continuous Deployment maintenance 🔧 Updates and upgrades labels Jul 20, 2022
@mrharpo mrharpo added this to the v0.2.0 Deploy 🌇 milestone Jul 20, 2022
@mrharpo mrharpo requested a review from afred July 20, 2022 14:38
@mrharpo mrharpo self-assigned this Jul 20, 2022
afred
afred approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit d4b5f1c into main Jul 20, 2022
@afred afred deleted the wgbhmla-nginx branch July 20, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
CD 🏗️ Relating to Continuous Deployment maintenance 🔧 Updates and upgrades
Projects
No open projects
OV Redesign 2022
Status: ✅ Done
Milestone
v0.2.0 Deploy 🌇
Development

Successfully merging this pull request may close these issues.

Migrate nginx image to wgbhmla
2 participants
@mrharpo @afred