Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌎 GUID Resolution #92

Merged
merged 2 commits into from
Aug 2, 2023
Merged

🌎 GUID Resolution #92

merged 2 commits into from
Aug 2, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Aug 1, 2023

GUID Resolver

Adds SonyCiAsset.filename -> MediaFile.guid resolver in IngestFlow

  • Links MediaFile <--> SonyCiAsset

Includes iPython notebook with example

Models

  • Migrates to MediaFile.guid as primary key to enforce uniqueness
  • Creates MediaFile.assets and SonyCiAsset.media_files Relationship()
  • Was not able to migrate successfully from existing migrations
    • Includes new fresh migration

Closes #90

@mrharpo mrharpo added the enhancement ➕ New feature or request label Aug 1, 2023
@mrharpo mrharpo requested a review from afred August 1, 2023 17:42
@mrharpo mrharpo self-assigned this Aug 1, 2023
@mrharpo mrharpo temporarily deployed to Codecov August 1, 2023 17:43 — with GitHub Actions Inactive
afred
afred approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 250d180 into main Aug 2, 2023
8 checks passed
@afred afred deleted the guids branch August 2, 2023 13:43
@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afred afred afred approved these changes

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.3.0 Pipeline 🚰
Development

Successfully merging this pull request may close these issues.

GUID Resolution
2 participants
@mrharpo @afred