🏭 Factories #8
Merged
🏭 Factories #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses pydantic-factories package to add factories for generating test data for Chowda models. Also: * Adds *.sqlite to gitignore.
mrharpo
approved these changes
Mar 23, 2023
chowda/factories.py
Outdated
| async with AsyncSession(engine) as session: | ||
| for d in data: | ||
| session.add(d) | ||
| await session.commit() |
There was a problem hiding this comment.
Shamelessly copied from fastapi/sqlmodel#161 (comment)
Unfortunately, running it gives me:
sqlalchemy.exc.InvalidRequestError: The asyncio extension requires an async driver to be used. The loaded 'pysqlite' is not async.
But I think that's enough proof it works, so we should include it and we'll test it when we swap out for an async driver.
chowda/db.py
Outdated
There was a problem hiding this comment.
Even creating the async engine throws the same sqlalchemy.exc.InvalidRequestError, hence the protection.
mrharpo
approved these changes
Mar 24, 2023
* main: Basic load testing with locust Basic docs structure Adds launch.json config for tests Adds stinkin' badges Adds sugar, xdist to pytest Adds first test! Adds flake8 and codecov defaults Remove environment, use new default Add version tags for workflows Adds CI tests and badges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses pydantic-factories package to add factories for generating test data for Chowda models.
Also: