Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📬 POST /api/sony_ci/sync #79

Merged
merged 10 commits into from
Jul 20, 2023
Merged

📬 POST /api/sony_ci/sync #79

merged 10 commits into from
Jul 20, 2023

Conversation

afred
Copy link
Contributor

@afred afred commented Jul 11, 2023 •
edited by mrharpo
Loading

API: Sync

Adds /api/sony_ci/sync action

Closes #51

@afred afred temporarily deployed to Codecov July 11, 2023 15:22 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 11, 2023 16:46 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 11, 2023 16:46 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 11, 2023 16:50 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 11, 2023 16:50 — with GitHub Actions Inactive
@mrharpo mrharpo changed the title Adds route POST /api/sony_ci/sync 📬 POST /api/sony_ci/sync Jul 12, 2023
@afred afred temporarily deployed to Codecov July 12, 2023 15:30 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 12, 2023 15:30 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #79 (3b92234) into main (0540e4d) will increase coverage by 1.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   81.56%   82.63%   +1.06%     
==========================================
  Files           9       12       +3     
  Lines         358      380      +22     
==========================================
+ Hits          292      314      +22     
  Misses         66       66
Impacted Files Coverage Δ
chowda/api.py 100.00% <100.00%> (ø)
chowda/app.py 100.00% <100.00%> (ø)
chowda/routers/__init__.py 100.00% <100.00%> (ø)
chowda/routers/sony_ci.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afred afred temporarily deployed to Codecov July 12, 2023 15:33 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 12, 2023 15:33 — with GitHub Actions Inactive
@afred afred marked this pull request as ready for review July 12, 2023 15:48
@afred afred requested a review from mrharpo July 12, 2023 15:51
mrharpo
mrharpo reviewed Jul 12, 2023
View reviewed changes
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/sync should return immediately, and results should be handled asynchronously.

chowda/routers/sony_ci.py Outdated Show resolved Hide resolved
@mrharpo mrharpo added the enhancement ➕ New feature or request label Jul 12, 2023
@afred afred temporarily deployed to Codecov July 19, 2023 15:01 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 19, 2023 15:01 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 19, 2023 15:03 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 19, 2023 15:03 — with GitHub Actions Inactive
@afred
Adds endpoint /sony_ci/sync
30cc335 
* Adds router to handle route for /sony_ci/sync
  * This publishes Argo event 'sync', which triggers IngestFlow (a Metaflow FlowSpec).
* Adds specs for testing success and failure of publising the 'sync' event.

Closes #51.
@afred afred temporarily deployed to Codecov July 19, 2023 15:39 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 19, 2023 15:39 — with GitHub Actions Inactive
@afred afred requested a review from mrharpo July 19, 2023 16:39
@afred afred temporarily deployed to Codecov July 19, 2023 19:35 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov July 19, 2023 19:35 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 16:19 — with GitHub Actions Inactive
@mrharpo
Merge branch 'main' into 51-api-endpoint-for-sync
6dff17c 
* main:
  🤖 Update dependencies (#83)
mrharpo
mrharpo approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo mrharpo temporarily deployed to Codecov July 20, 2023 18:35 — with GitHub Actions Inactive
afred
afred commented Jul 20, 2023
View reviewed changes
Copy link
Contributor Author

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit 2208e56 into main Jul 20, 2023
5 checks passed
@afred afred deleted the 51-api-endpoint-for-sync branch July 20, 2023 18:42
@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrharpo mrharpo mrharpo approved these changes

Assignees

@afred afred

Labels
enhancement ➕ New feature or request
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.3.0 Pipeline 🚰
Development

Successfully merging this pull request may close these issues.

API: Sync
3 participants
@afred @codecov-commenter @mrharpo