Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📼 VCR.py #46

Merged
merged 3 commits into from
May 22, 2023
Merged

📼 VCR.py #46

merged 3 commits into from
May 22, 2023

Conversation

afred
Copy link
Contributor

@afred afred commented May 22, 2023 •
edited by mrharpo
Loading

VCR.py

  • Adds pytest-vcr to recod Sony Ci API interactions for tests
  • Adds conftest.py from sonyci
    • Request / Response cleaners
  • Adds ci.test.toml for tests
  • Adds --vcr-record=none to .vscode settings.json

Pre-commit

Adds pre-commit config for GitGuardian protection

Misc

  • .gitignore ci.toml

@afred afred temporarily deployed to Codecov May 22, 2023 16:06 — with GitHub Actions Inactive
@afred afred mentioned this pull request May 22, 2023
Closed
@afred afred requested a review from mrharpo May 22, 2023 16:08
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023 •
edited
Loading

Codecov Report

Merging #46 (cf96c4b) into main (9d872d4) will not change coverage.
The diff coverage is n/a.

❗ Current head cf96c4b differs from pull request most recent head e877c52. Consider uploading reports for the commit e877c52 to get more accurate results

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   81.33%   81.33%           
=======================================
  Files           9        9           
  Lines         300      300           
=======================================
  Hits          244      244           
  Misses         56       56
Impacted Files Coverage Δ
chowda/models.py 87.61% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo added this to the v0.3 Pipeline 🚰 milestone May 22, 2023
afred
afred commented May 22, 2023
View reviewed changes
chowda/models.py Outdated Show resolved Hide resolved
@afred afred temporarily deployed to Codecov May 22, 2023 17:14 — with GitHub Actions Inactive
@afred afred temporarily deployed to Codecov May 22, 2023 17:14 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov May 22, 2023 17:17 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov May 22, 2023 17:17 — with GitHub Actions Inactive
mrharpo
mrharpo approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@mrharpo mrharpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mrharpo mrharpo changed the title Adds pytest-vcr to recod Sony Ci API interactions for tests 📼 VCR.py May 22, 2023
@mrharpo mrharpo merged commit 2078a47 into main May 22, 2023
@mrharpo mrharpo deleted the add-vcr-config branch May 22, 2023 17:20
mrharpo added a commit that referenced this pull request May 22, 2023
@mrharpo
Merge branch 'main' into docs
751e676 
* main:
  📼 VCR.py (#46)
  🤖 Update dependencies (#37)
  🕸 Debug (#45)
  🌄 Custom views (#43)
  Fixes app location in dockerfile (#44)
  Updates Collection and Batch list view (#42)
  📛 ClamsApp name (#41)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrharpo mrharpo mrharpo approved these changes

Assignees

@afred afred

Labels
None yet
Projects
No open projects
Chowda 2023
Status: ✅ Done
Milestone
v0.3.0 Pipeline 🚰
Development

Successfully merging this pull request may close these issues.
3 participants
@afred @codecov-commenter @mrharpo