🍝 SonyCiAsset #36
🍝 SonyCiAsset #36
Conversation
mrharpo
added
documentation 📜
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
+ Coverage 82.87% 84.80% +1.92%
==========================================
Files 9 9
Lines 292 329 +37
==========================================
+ Hits 242 279 +37
Misses 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chowda/models.py
Outdated
| __tablename__ = 'media_files' | ||
| id: Optional[int] = Field(primary_key=True) | ||
| id: Optional[str] = Field(primary_key=True) |
There was a problem hiding this comment.
If we keep the sonyci_id as it's own field (not primary key) it'll be easier to use Chowda with media from other locations later on.
Is there a specific benefit to making the Sony Ci ID the id field rather than it's own, unique, indexed sonyci_id field?
docs/examples/ingest.ipynb
Outdated
| "def batch_ingest_session(n):\n", | ||
| " with Session(engine) as session:\n", | ||
| " batch = get_batch(n)\n", | ||
| " media = [MediaFile(guid=asset['name'], id=asset['id']) for asset in batch]\n", |
There was a problem hiding this comment.
guid will need to be mapped from a filename like cpb-aacip-123-45678.rando-filename-arbitrariness.mp4.mp4 to cpb-aacip-123-45678... regex ftw!
docs/examples/ingest.ipynb
Outdated
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "def get_batch(n):\n", |
There was a problem hiding this comment.
if we pull this out of a notebook and into real code, we may want to consider different terminology than batch to avoid confusion with the db model
* Adds a Chowda db model for storing Sony Ci Asset JSON to be related to Chowda MediaFile models. * Adds SonyCiAsset model to Starlette admin UI. Also, * Adds ci.toml to .gitignore. Co-authored-by: Harpo <ryan@dellarteproductions.com> Adds model
SonyCiAsset
Adds
SonyCiAssetmodelSonyCiAssetView
Adds view for SonyCiAssets
Enums
MediaTypeThumbnailTypelarge, medium, small, standard, video-sd, video-3g