-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📙 page_size_options
#156
Merged
📙 page_size_options
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
+ Coverage 67.96% 68.31% +0.34%
==========================================
Files 18 19 +1
Lines 668 770 +102
==========================================
+ Hits 454 526 +72
- Misses 214 244 +30
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
afred
reviewed
Sep 19, 2023
afred
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page_size_options
Adds default page sizes for all model views:
[10, 25, 100, 1000, -1]
where-1
is "All"MediaFile
andSonyCiAsset
ViewsLimits to 10k for performance reasons (see 👇):
[10, 25, 100, 500, 2000, 10000]
View All AssetsIt is technically possible to show "All" SonyCiAssets with
-1
, but queries that large (180k rows) broke the server.Rows displayed after the first few thousand make the page basically unresponsive, so capped at
10k
With 10k rows:
Closes #146
Misc
BaseModelView
->ChowdaModelView
small
thumbnails for list view