Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📙 page_size_options #156

Merged
merged 7 commits into from
Sep 19, 2023
Merged

📙 page_size_options #156

merged 7 commits into from
Sep 19, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Sep 18, 2023

page_size_options

Adds default page sizes for all model views: [10, 25, 100, 1000, -1] where -1 is "All"

MediaFile and SonyCiAsset Views

Limits to 10k for performance reasons (see 👇): [10, 25, 100, 500, 2000, 10000]

View All Assets

It is technically possible to show "All" SonyCiAssets with -1, but queries that large (180k rows) broke the server.

  • Including when pod was allowed extra resources, and allowed 2 minutes to respond.

Rows displayed after the first few thousand make the page basically unresponsive, so capped at 10k

With 10k rows:

  • Server request time: ~ 5s
  • Request download time: ~ 20s (10MB)
  • Page load time: ~ 20s after download.

Closes #146

Misc

  • Changes BaseModelView -> ChowdaModelView
  • Uses small thumbnails for list view
  • Lazy load thumbnails

@mrharpo mrharpo added the enhancement ➕ New feature or request label Sep 18, 2023
@mrharpo mrharpo requested a review from afred September 18, 2023 18:20
@mrharpo mrharpo self-assigned this Sep 18, 2023
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 18:20 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 19:42 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 19:42 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #156 (3d4e5aa) into main (dbbc063) will increase coverage by 0.34%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   67.96%   68.31%   +0.34%     
==========================================
  Files          18       19       +1     
  Lines         668      770     +102     
==========================================
+ Hits          454      526      +72     
- Misses        214      244      +30     
Files Changed Coverage Δ
chowda/fields.py 83.50% <50.00%> (ø)
chowda/views.py 48.00% <100.00%> (+1.52%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 20:20 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 20:20 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 20:57 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 20:57 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 21:08 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 21:08 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 21:24 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 18, 2023 21:24 — with GitHub Actions Inactive
pyproject.toml Outdated Show resolved Hide resolved
chowda/fields.py Show resolved Hide resolved
@mrharpo mrharpo temporarily deployed to Codecov September 19, 2023 17:02 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 19, 2023 17:02 — with GitHub Actions Inactive
@mrharpo mrharpo requested a review from afred September 19, 2023 17:07
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afred afred merged commit f8752bd into main Sep 19, 2023
8 checks passed
@afred afred deleted the row-count branch September 19, 2023 19:13
@mrharpo mrharpo added this to the v0.4.0 Chowda 🍲 milestone Sep 19, 2023
@mrharpo mrharpo mentioned this pull request Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Change row count values
3 participants