Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 MetaflowRuns #141

Merged
merged 9 commits into from
Sep 11, 2023
Merged

🏃 MetaflowRuns #141

merged 9 commits into from
Sep 11, 2023

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Sep 6, 2023

MetaflowRuns

Adds fields to MetaflowRun table for caching results in Chowda db

  • finished: bool
  • successful: bool
  • created_at: datetime
    • with timezone
    • default utcnow
  • finished_at: datetime
    • with timezone

BatchMetaflowRunDisplayField

Migrates BatchMediaFileDisplayField -> BatchMetaflowRunDisplayField

  • Adds ✅ and ❌ icons for finished and successful

Closes #67

Screen Shot 2023-09-08 at 11 02 27

@mrharpo mrharpo added the enhancement ➕ New feature or request label Sep 6, 2023
@mrharpo mrharpo self-assigned this Sep 6, 2023
@mrharpo mrharpo temporarily deployed to Codecov September 6, 2023 20:17 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 6, 2023 21:10 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 6, 2023 21:10 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2023

Codecov Report

Merging #141 (1f95938) into main (a02b08b) will increase coverage by 0.12%.
The diff coverage is 34.88%.

@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   67.46%   67.59%   +0.12%     
==========================================
  Files          18       18              
  Lines         707      719      +12     
==========================================
+ Hits          477      486       +9     
- Misses        230      233       +3     
Files Changed Coverage Δ
chowda/fields.py 63.82% <17.64%> (-1.73%) ⬇️
chowda/app.py 100.00% <100.00%> (ø)
chowda/models.py 87.91% <100.00%> (+0.41%) ⬆️
chowda/views.py 46.47% <100.00%> (+0.63%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrharpo mrharpo requested a review from afred September 6, 2023 22:42
@mrharpo mrharpo marked this pull request as ready for review September 6, 2023 22:42
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 16:59 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 16:59 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:05 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:05 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:15 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:15 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:39 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:39 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:40 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 17:40 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 18:21 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 18:21 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 19:17 — with GitHub Actions Inactive
@mrharpo mrharpo temporarily deployed to Codecov September 8, 2023 19:17 — with GitHub Actions Inactive
@mrharpo mrharpo added this to the v0.4.0 Chowda 🍲 milestone Sep 8, 2023
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with caveat that we'll probably want to switch Batch Detail view back to using a media file view, so that it will display media files for which there are not yet any Metaflow Runs, but we can merge this now and build off it.

@afred afred merged commit 22c5aed into main Sep 11, 2023
8 checks passed
@afred afred deleted the metaflow-runs branch September 11, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Update ClamsEvents view
3 participants